FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
793 75 0 0

Files

Class Bugs
org.jcurl.demo.jtree.AbstractTreeTransferHandler 3
org.jcurl.demo.jtree.DNDTree 2
org.jcurl.demo.jtree.TransferableNode 1
org.jcurl.demo.smack.ChatSimpleSwingBean 1
org.jcurl.demo.smack.JCurlSmackClient$GuiUtil 3
org.jcurl.demo.smack.JCurlSmackClient$XmppAccount 2
org.jcurl.demo.smack.RosterSimpleSwingBean 2
org.jcurl.demo.smack.SmackChangeManager 1
org.jcurl.demo.smack.SmackChangeManager$MementoPackageExtension 1
org.jcurl.demo.tactics.BirdScenarioBean 2
org.jcurl.demo.tactics.BroomPromptSwingBean 4
org.jcurl.demo.tactics.CurlerSwingBean 1
org.jcurl.demo.tactics.JCurlShotPlanner 4
org.jcurl.demo.tactics.JSpinnerNumberUnit 6
org.jcurl.demo.tactics.TrajectoryPiccoloBean 7
org.jcurl.demo.tactics.TrajectoryScenarioBean 13
org.jcurl.demo.tactics.old.ActionRegistry$2 2
org.jcurl.demo.tactics.old.MainApp 2
org.jcurl.demo.tactics.old.MainApp$1 1
org.jcurl.demo.tactics.old.MenuFile$Controller 2
org.jcurl.demo.tactics.old.MenuFile$Controller$1 1
org.jcurl.demo.tactics.old.MenuFile$Controller$2 1
org.jcurl.demo.tactics.old.MenuFile$Model 1
org.jcurl.demo.tactics.sg.BroomPromptScenario 6
org.jcurl.demo.util.RealTimePlayer 3
org.jcurl.demo.zui.BroomPromptDemo 1
org.jcurl.mr.gui.Model 2

org.jcurl.demo.jtree.AbstractTreeTransferHandler

Bug Category Details Line
Write to static field org.jcurl.demo.jtree.AbstractTreeTransferHandler.draggedNode from instance method org.jcurl.demo.jtree.AbstractTreeTransferHandler.dragGestureRecognized(DragGestureEvent) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 125
Write to static field org.jcurl.demo.jtree.AbstractTreeTransferHandler.image from instance method org.jcurl.demo.jtree.AbstractTreeTransferHandler.dragGestureRecognized(DragGestureEvent) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 142
Unread field: org.jcurl.demo.jtree.AbstractTreeTransferHandler.dropTarget PERFORMANCE URF_UNREAD_FIELD 71

org.jcurl.demo.jtree.DNDTree

Bug Category Details Line
Exception is caught when Exception is not thrown in org.jcurl.demo.jtree.DNDTree.main(String[]) STYLE REC_CATCH_EXCEPTION 77
Call to swing method in org.jcurl.demo.jtree.DNDTree.main(String[]) needs to be performed in Swing event thread BAD_PRACTICE SW_SWING_METHODS_INVOKED_IN_SWING_THREAD 76

org.jcurl.demo.jtree.TransferableNode

Bug Category Details Line
org.jcurl.demo.jtree.TransferableNode.getTransferDataFlavors() may expose internal representation by returning TransferableNode.flavors MALICIOUS_CODE EI_EXPOSE_REP 53

org.jcurl.demo.smack.ChatSimpleSwingBean

Bug Category Details Line
Class org.jcurl.demo.smack.ChatSimpleSwingBean defines non-transient non-serializable instance field chat BAD_PRACTICE SE_BAD_FIELD Not available

org.jcurl.demo.smack.JCurlSmackClient$GuiUtil

Bug Category Details Line
Private method org.jcurl.demo.smack.JCurlSmackClient$GuiUtil.createFileChooser(File, String, FileFilter) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 154-160
Private method org.jcurl.demo.smack.JCurlSmackClient$GuiUtil.createFileFilter(String, String[]) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 165-168
Private method org.jcurl.demo.smack.JCurlSmackClient$GuiUtil.ensureSuffix(File, FileNameExtensionFilter) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 204-206

org.jcurl.demo.smack.JCurlSmackClient$XmppAccount

Bug Category Details Line
JCurlSmackClient$XmppAccount.pwd not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
JCurlSmackClient$XmppAccount.uid not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.jcurl.demo.smack.RosterSimpleSwingBean

Bug Category Details Line
Class org.jcurl.demo.smack.RosterSimpleSwingBean defines non-transient non-serializable instance field chatManager BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.smack.RosterSimpleSwingBean defines non-transient non-serializable instance field roster BAD_PRACTICE SE_BAD_FIELD Not available

org.jcurl.demo.smack.SmackChangeManager

Bug Category Details Line
Dead store to id in org.jcurl.demo.smack.SmackChangeManager.fromXml(String) STYLE DLS_DEAD_LOCAL_STORE 103

org.jcurl.demo.smack.SmackChangeManager$MementoPackageExtension

Bug Category Details Line
Should org.jcurl.demo.smack.SmackChangeManager$MementoPackageExtension be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC Not available

org.jcurl.demo.tactics.BirdScenarioBean

Bug Category Details Line
Class org.jcurl.demo.tactics.BirdScenarioBean defines non-transient non-serializable instance field scene BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.BirdScenarioBean defines non-transient non-serializable instance field zoom BAD_PRACTICE SE_BAD_FIELD Not available

org.jcurl.demo.tactics.BroomPromptSwingBean

Bug Category Details Line
Test for floating point equality in org.jcurl.demo.tactics.BroomPromptSwingBean.stateChanged(ChangeEvent) STYLE FE_FLOATING_POINT_EQUALITY 347
Redundant nullcheck of org.jcurl.demo.tactics.BroomPromptSwingBean.broom, which is known to be non-null in org.jcurl.demo.tactics.BroomPromptSwingBean.updateIndex() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 452
Class org.jcurl.demo.tactics.BroomPromptSwingBean defines non-transient non-serializable instance field broom BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.BroomPromptSwingBean defines non-transient non-serializable instance field changer BAD_PRACTICE SE_BAD_FIELD Not available

org.jcurl.demo.tactics.CurlerSwingBean

Bug Category Details Line
Class org.jcurl.demo.tactics.CurlerSwingBean defines non-transient non-serializable instance field changer BAD_PRACTICE SE_BAD_FIELD Not available

org.jcurl.demo.tactics.JCurlShotPlanner

Bug Category Details Line
Write to static field org.jcurl.demo.tactics.JCurlShotPlanner.initialScene from instance method org.jcurl.demo.tactics.JCurlShotPlanner.initialize(String[]) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 840
Write to static field org.jcurl.demo.tactics.JCurlShotPlanner.templateScene from instance method org.jcurl.demo.tactics.JCurlShotPlanner.initialize(String[]) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 842
Private method org.jcurl.demo.tactics.JCurlShotPlanner.createToolBar() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 570-579
Private method org.jcurl.demo.tactics.JCurlShotPlanner.fileClear() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 623-630

org.jcurl.demo.tactics.JSpinnerNumberUnit

Bug Category Details Line
org.jcurl.demo.tactics.JSpinnerNumberUnit.setChoose(Unit[]) may expose internal representation by storing an externally mutable object into JSpinnerNumberUnit.choose MALICIOUS_CODE EI_EXPOSE_REP2 181
Comparison of String parameter using == or != in org.jcurl.demo.tactics.JSpinnerNumberUnit.setLabel(String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 209
Test for floating point equality in org.jcurl.demo.tactics.JSpinnerNumberUnit.setValue(double) STYLE FE_FLOATING_POINT_EQUALITY 260
Test for floating point equality in org.jcurl.demo.tactics.JSpinnerNumberUnit.stateChanged(ChangeEvent) STYLE FE_FLOATING_POINT_EQUALITY 284
The field org.jcurl.demo.tactics.JSpinnerNumberUnit.change is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available
The field org.jcurl.demo.tactics.JSpinnerNumberUnit.oldValueBase is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available

org.jcurl.demo.tactics.TrajectoryPiccoloBean

Bug Category Details Line
Dead store to home in org.jcurl.demo.tactics.TrajectoryPiccoloBean.TrajectoryPiccoloBean() STYLE DLS_DEAD_LOCAL_STORE 205
Dead store to out in org.jcurl.demo.tactics.TrajectoryPiccoloBean.TrajectoryPiccoloBean() STYLE DLS_DEAD_LOCAL_STORE 206
Class org.jcurl.demo.tactics.TrajectoryPiccoloBean defines non-transient non-serializable instance field mouse BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryPiccoloBean defines non-transient non-serializable instance field tf BAD_PRACTICE SE_BAD_FIELD Not available
org.jcurl.demo.tactics.TrajectoryPiccoloBean$MoveHandler stored into non-transient field TrajectoryPiccoloBean.mouse BAD_PRACTICE SE_BAD_FIELD_STORE 157
org.jcurl.zui.piccolo.PTrajectoryFactory$Fancy stored into non-transient field TrajectoryPiccoloBean.tf BAD_PRACTICE SE_BAD_FIELD_STORE 163
Unread field: org.jcurl.demo.tactics.TrajectoryPiccoloBean.AnimationMillis; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 153

org.jcurl.demo.tactics.TrajectoryScenarioBean

Bug Category Details Line
Class org.jcurl.demo.tactics.TrajectoryScenarioBean implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field broom BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field current BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field dc2wc BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field initial BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field mouse BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field opa_r0 BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field opa_r1 BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field opa_t0 BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field path BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field rocks BAD_PRACTICE SE_BAD_FIELD Not available
Class org.jcurl.demo.tactics.TrajectoryScenarioBean defines non-transient non-serializable instance field zoom BAD_PRACTICE SE_BAD_FIELD Not available
The field org.jcurl.demo.tactics.TrajectoryScenarioBean.tf is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available

org.jcurl.demo.tactics.old.ActionRegistry$2

Bug Category Details Line
Class org.jcurl.demo.tactics.old.ActionRegistry$2 defines non-transient non-serializable instance field val$m BAD_PRACTICE SE_BAD_FIELD Not available
The class org.jcurl.demo.tactics.old.ActionRegistry$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

org.jcurl.demo.tactics.old.MainApp

Bug Category Details Line
Call to swing method in org.jcurl.demo.tactics.old.MainApp.main(String[]) needs to be performed in Swing event thread BAD_PRACTICE SW_SWING_METHODS_INVOKED_IN_SWING_THREAD 55
Usage of GetResource in org.jcurl.demo.tactics.old.MainApp.MainApp() may be unsafe if class is extended BAD_PRACTICE UI_INHERITANCE_UNSAFE_GETRESOURCE 89

org.jcurl.demo.tactics.old.MainApp$1

Bug Category Details Line
The class org.jcurl.demo.tactics.old.MainApp$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

org.jcurl.demo.tactics.old.MenuFile$Controller

Bug Category Details Line
Dead store to cu in org.jcurl.demo.tactics.old.MenuFile$Controller.exitFile() STYLE DLS_DEAD_LOCAL_STORE 178
Hard coded reference to an absolute pathname in org.jcurl.demo.tactics.old.MenuFile$Controller.exportSvg() STYLE DMI_HARDCODED_ABSOLUTE_FILENAME 188

org.jcurl.demo.tactics.old.MenuFile$Controller$1

Bug Category Details Line
The class org.jcurl.demo.tactics.old.MenuFile$Controller$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

org.jcurl.demo.tactics.old.MenuFile$Controller$2

Bug Category Details Line
The class org.jcurl.demo.tactics.old.MenuFile$Controller$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

org.jcurl.demo.tactics.old.MenuFile$Model

Bug Category Details Line
MenuFile$Model.tpm not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.jcurl.demo.tactics.sg.BroomPromptScenario

Bug Category Details Line
Dead store to a in org.jcurl.demo.tactics.sg.BroomPromptScenario.BroomPromptScenario() STYLE DLS_DEAD_LOCAL_STORE 267
Dead store to ar in org.jcurl.demo.tactics.sg.BroomPromptScenario.BroomPromptScenario() STYLE DLS_DEAD_LOCAL_STORE 256
Dead store to arrowLengthDegrees in org.jcurl.demo.tactics.sg.BroomPromptScenario.BroomPromptScenario() STYLE DLS_DEAD_LOCAL_STORE 241
Dead store to off in org.jcurl.demo.tactics.sg.BroomPromptScenario.BroomPromptScenario() STYLE DLS_DEAD_LOCAL_STORE 239
Dead store to pieAngle in org.jcurl.demo.tactics.sg.BroomPromptScenario.BroomPromptScenario() STYLE DLS_DEAD_LOCAL_STORE 213
Dead store to pieOff in org.jcurl.demo.tactics.sg.BroomPromptScenario.BroomPromptScenario() STYLE DLS_DEAD_LOCAL_STORE 240

org.jcurl.demo.util.RealTimePlayer

Bug Category Details Line
Dead store to speed in org.jcurl.demo.util.RealTimePlayer.run() STYLE DLS_DEAD_LOCAL_STORE 70
Dead store to pos in org.jcurl.demo.util.RealTimePlayer.run() STYLE DLS_DEAD_LOCAL_STORE 69
Unread field: org.jcurl.demo.util.RealTimePlayer.timeSleep; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 45

org.jcurl.demo.zui.BroomPromptDemo

Bug Category Details Line
Dead store to pi in org.jcurl.demo.zui.BroomPromptDemo.animateToBounds(PCamera, Rectangle2D, long) STYLE DLS_DEAD_LOCAL_STORE 81

org.jcurl.mr.gui.Model

Bug Category Details Line
Dead store to PRIME in org.jcurl.mr.gui.Model.hashCode() STYLE DLS_DEAD_LOCAL_STORE 130
org.jcurl.mr.gui.Model.equals(Object) does not check for null argument BAD_PRACTICE NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT 67